Re: [PATCH 8/8] vm: Add an tuning knob for vm.max_writeback_mb

[Jens Axboe]

On Wed, Sep 09 2009, Christoph Hellwig wrote:
> On Wed, Sep 09, 2009 at 02:37:46PM +0200, Jens Axboe wrote:
> > They are there, have been for months! But I think Christoph is a little
> > confused, we'll still do writeback inline from balance_dirty_pages(). It
> > does writeback_inodes_wbc(), which does not schedule async writeout.
> 
> Hmm, at least the version I have applied right now calls
> bdi_start_writeback and not writeback_inodes_wbc from
> balance_dirty_pages.  But you sent our another spin or two afer those,
> so maybe it changed again.

Yes, that's the very end check, the old code does the same. Further up
it does writeback_inodes_wbc() if we are over the threshold.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/