Re: [PATCH 1/2] tracing: Add sysctl to enable/disable tracing onoops

From: Li Zefan
Date: Tue Sep 08 2009 - 21:48:47 EST


Steven Rostedt wrote:
> On Wed, 2009-09-09 at 09:37 +0800, Li Zefan wrote:
>> Steven Rostedt wrote:
>>> On Wed, 2009-09-09 at 09:15 +0800, Li Zefan wrote:
>>>> Currently we always disable tracing on oops, and this patch
>>>> adds a sysctl so one can choose to enable it.
>>> Hmm, we already have a way to enable it.
>>>
>>> # echo 1 > /debug/tracing/tracing_on
>>>
>> What I want is a way to not disable it when an oops happened. :)
>>
>
> Ah, I misunderstood. May I ask a silly question?
>
> Why?
>

Otherwise we won't get trace output from trae_crash_kexec if
crash_kexec() is not called by panic(). For example:

oops_begin()
->trace_off()
->panic_on_oops
->kexec_should_crash()
->crash_kexec()
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/