Re: [PATCH tip/core/rcu 0/3] increase rcutorture intensity and fixa couple resulting bugs

[Steven Rostedt]

On Tue, 2009-09-08 at 15:53 -0700, Paul E. McKenney wrote:
> This patch series increases the intensity of rcutorture testing for
> TREE_PREEMPT_RCU and provides fixes for a couple resulting bugs.
> 
> o	Make rcutorture's RCU read-side critical sections occasionally
> 	spin for a few tens of milliseconds, which greatly increases
> 	the probability that they will be preempted and that quiescent
> 	states will be forced.  Yes, this does uncover some bugs in
> 	TREE_PREEMPT_RCU (though TREE_RCU passes with flying colors).
> 
> o	Fix a bug where rnp->gpnum was not being updated.  This
> 	increases TREE_PREEMPT_RCU's reliability considerably, though
> 	bugs still remain.
> 
> o	Make the initialization of multi-node trees of rcu_node
> 	structures unconditionally acquire rnp->lock.  This simplifies
> 	the code a bit and will make it easier to allow grace-period
> 	initialization become preemptable, should this be needed.
> 
> Next steps include applying review comments, adding expedited grace
> periods, and chasing down remaining bugs.  Longer term, RCU priority
> boosting.

Hi Paul,

These patches look decent to me.

If it makes you feel comfy:

Acked-by: Steven Rostedt <rostedt@xxxxxxxxxxx>

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/