Re: [PATCH] trace bio queueing trial only when it occurs

[Minchan Kim]

On Tue, Sep 8, 2009 at 1:13 PM, Wu Fengguang<fengguang.wu@xxxxxxxxx> wrote:
> On Tue, Sep 08, 2009 at 12:10:55PM +0800, Minchan Kim wrote:
>> On Tue, Sep 8, 2009 at 11:02 AM, Li Zefan<lizf@xxxxxxxxxxxxxx> wrote:
>> > Wu Fengguang wrote:
>> >> Minchan,
>> >>
>> >> I tend to agree with the change, but somehow confused by blkparse(1):
>> >>
>> >>         Q -- queued   This notes *intent* to queue i/o at the given location.  No real requests exists yet.
>> >>
>> >> Li Zefan has been working on blktrace and he can tell more.
>> >>
>> >
>> > I work on ftrace-plugin blktrace and blk TRACE_EVENT, but don't know
>> > much about the old blktrace history. ;)
>> >
>> > I think the manpage says it's called before ->make_request_fn(), so
>> > "No real requests exist yet".
>> >
>> > Actually the trace was called just before make_request at first:
>> >        2056a782f8e7e65fd4bfd027506b4ce1c5e9ccd4
>> >
>> > And then 2 patches added some checks between them:
>> >        5ddfe9691c91a244e8d1be597b6428fcefd58103
>> >        51fd77bd9f512ab6cc9df0733ba1caaab89eb957
>> >
>> > It seems to me it makes sense to have this patch.
>>
>> Thanks for good information.
>> Yes. It seems above 2 patches seem to break the rule.
>> Could I add your ACK?
>
> Sure, thanks!
>
> Acked-by: Wu Fengguang <fengguang.wu@xxxxxxxxx>

Thanks for careful review, Wu.



-- 
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/