[tip:sched/balancing] sched: Remove short cut from select_task_rq_fair()

From: tip-bot for Peter Zijlstra
Date: Mon Sep 07 2009 - 16:37:57 EST

Commit-ID: cdd2ab3de4301728b20efd6225681d3ff591a938
Gitweb: http://git.kernel.org/tip/cdd2ab3de4301728b20efd6225681d3ff591a938
Author: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
AuthorDate: Mon, 7 Sep 2009 18:12:06 +0200
Committer: Ingo Molnar <mingo@xxxxxxx>
CommitDate: Mon, 7 Sep 2009 20:39:05 +0200

sched: Remove short cut from select_task_rq_fair()

select_task_rq_fair() incorrectly skips the wake_affine()
logic, remove this.

When prev_cpu == this_cpu, the code jumps straight to the
wake_idle() logic, this doesn't give the wake_affine() logic
the chance to pin the task to this cpu.

Signed-off-by: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@xxxxxxx>

kernel/sched_fair.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c
index 2ff850f..d7fda41 100644
--- a/kernel/sched_fair.c
+++ b/kernel/sched_fair.c
@@ -1305,8 +1305,6 @@ static int select_task_rq_fair(struct task_struct *p, int sync)
this_rq = cpu_rq(this_cpu);
new_cpu = prev_cpu;

- if (prev_cpu == this_cpu)
- goto out;
* 'this_sd' is the first domain that both
* this_cpu and prev_cpu are present in:
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/