[patch 62/71] ipv4: make ip_append_data() handle NULL routing table

From: Greg KH
Date: Fri Sep 04 2009 - 20:24:39 EST

2.6.30-stable review patch. If anyone has any objections, please let us know.

From: Julien TINNES <julien@xxxxxxx>

commit 788d908f2879a17e5f80924f3da2e23f1034482d upstream.

Add a check in ip_append_data() for NULL *rtp to prevent future bugs in
callers from being exploitable.

Signed-off-by: Julien Tinnes <julien@xxxxxxx>
Signed-off-by: Tavis Ormandy <taviso@xxxxxxxxxxxxxxxx>
Acked-by: David S. Miller <davem@xxxxxxxxxxxxx>
Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>

net/ipv4/ip_output.c | 2 ++
1 file changed, 2 insertions(+)

--- a/net/ipv4/ip_output.c
+++ b/net/ipv4/ip_output.c
@@ -814,6 +814,8 @@ int ip_append_data(struct sock *sk,
inet->cork.addr = ipc->addr;
rt = *rtp;
+ if (unlikely(!rt))
+ return -EFAULT;
* We steal reference to this route, caller should not release it

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/