[PATCH] ncpfs: fix selection of NLS

From: Jan Beulich
Date: Fri Sep 04 2009 - 03:59:43 EST

In order for nls_base to really be compilable as a module, the select
from ncpfs needs to be corrected: Boolean sub-options of tristate
options selecting another tristate option should not do the select
themselves, as that forces the selected option to Y. Instead, a
conditional select in the base tristate option is needed.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

fs/ncpfs/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.31-rc8/fs/ncpfs/Kconfig 2009-03-24 00:12:14.000000000 +0100
+++ 2.6.31-rc8-ncpfs-nls-select/fs/ncpfs/Kconfig 2009-09-02 13:56:05.000000000 +0200
@@ -4,6 +4,7 @@
config NCP_FS
tristate "NCP file system support (to mount NetWare volumes)"
depends on IPX!=n || INET
+ select NLS if NCPFS_NLS
NCP (NetWare Core Protocol) is a protocol that runs over IPX and is
used by Novell NetWare clients to talk to file servers. It is to
@@ -86,7 +87,6 @@ config NCPFS_SMALLDOS
config NCPFS_NLS
bool "Use Native Language Support"
depends on NCP_FS
- select NLS
Allows you to use codepages and I/O charsets for file name
translation between the server file system and input/output. This

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/