Re: [PATCH 1/9] task_struct: add PF_NONOTIFY for fanotify to use

From: Eric Paris
Date: Thu Sep 03 2009 - 16:26:13 EST

> On Fri, Aug 28, 2009 at 02:55:42PM -0400, Eric Paris (eparis@xxxxxxxxxx) wrote:
> > Since fanotify opens file descriptors inside the kernel for it's listeners
> > it needs a way to make sure that 2 fanotify listeners, both which listen to
> > open events do not continuously see each others open events (and get into a
> > livelock reporting on each other's activity). This fix is to create a new
> > tast_struct flags called PF_NONOTIFY. If this flag is set in a task no
> > fanotify events will be generated for that task. fanotify will set the
> > flag before and open call and will clear it immediately after.

So this patch isn't actually needed, I thought the fsnotify_open() call
was deeper than it is. I'm going to drop this particular patch.

Can I take silence on the list as a lack of disagreement? I'd like to
start putting these into linux-next starting tomorrow. Obviously I'd
like to see the networking definitions approved and taken by davem, I'd
like to see the FMODE_ change approved and taken by viro, but if you two
would like me to push it directly I'd be happy to.

Davem, maybe you'd rather my af_fanotify was somewhere inside net/
instead of in fs/notify/fanotify? I'd love to get some review here, but
noone onlist is excited enough to step up. (I have numerous people who
have privately claimed they intend to use this stuff, so i promise it
won't be dead code.)

I'm ready to start committing and adding features, anyone telling me no?


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at