Re: [PATCH] pagemap: document KPF_KSM and show it in page-types

[Wu Fengguang]

On Tue, Sep 01, 2009 at 12:41:51AM +0800, Chris Wright wrote:
> * Wu Fengguang (fengguang.wu@xxxxxxxxx) wrote:
> > It indicates to the system admin that processes mapping such pages may be
> > eating less physical memory than the reported numbers by legacy tools.
> > 
> > CC: Hugh Dickins <hugh.dickins@xxxxxxxxxxxxx>
> > CC: Chris Wright <chrisw@xxxxxxxxxx>
> > CC: Izik Eidus <ieidus@xxxxxxxxxx>
> > Signed-off-by: Wu Fengguang <fengguang.wu@xxxxxxxxx>
> 
> Acked-by: Chris Wright <chrisw@xxxxxxxxxx>

Thanks.

> > --- linux-mm.orig/tools/vm/page-types.c	2009-08-31 15:00:24.000000000 +0800
> > +++ linux-mm/tools/vm/page-types.c	2009-08-31 15:02:10.000000000 +0800
> > @@ -49,6 +49,7 @@
> >  #define KPF_UNEVICTABLE		18
> >  #define KPF_HWPOISON		19
> >  #define KPF_NOPAGE		20
> > +#define KPF_KSM			21
> 
> Doesn't this highlight the trouble w/ maintaining two copies of same info?

Yes, I even had patch to move these numbers to page-flags.h.
however given that we have to update the flag name strings anyway,
this is not a big extra burden?

Thanks,
Fengguang

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/