Re: [PATCH 0/6] PM: Asynchronous suspend and resume of devices

From: Alan Stern
Date: Thu Aug 27 2009 - 16:46:19 EST


On Wed, 26 Aug 2009, Rafael J. Wysocki wrote:

> Hi,
>
> The following patches introduce a mechanism allowing us to execute device
> drivers' suspend and resume callbacks asynchronously during system sleep
> transitions, such as suspend to RAM.
>
> The idea is explained in the changelogs of the first two patches.
>
> Comments welcome.

I've been terribly busy and haven't had a chance to look at this. The
earlier version seemed to have a bunch of mutual-exclusion issues; are
they resolved now? There were also some problems involving unsafe
iteration over the dpm_list -- remember that devices can be
unregistered at any time, not just while they are suspending or
resuming.

When a device finishes, instead of having the async thread look for
another device to work on, I think it would be better to have the
thread check the dependents of the current device. Those which are
now ready can be added to a "device-ready" list, which is used to
direct the actions of new async threads.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/