Re: Linux 2.6.31-rc7

From: Eric Anholt
Date: Wed Aug 26 2009 - 02:27:14 EST

On Wed, 2009-08-26 at 13:47 +1000, Dave Airlie wrote:
> On Wed, Aug 26, 2009 at 1:33 PM, Linus
> Torvalds<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> >
> >
> > On Wed, 26 Aug 2009, Zhenyu Wang wrote:
> >>
> >> > In my experience, the BIOS setup doesn't reflect what outputs should be
> >> > used at runtime, and certainly not the correct configuration of the
> >> > enabled outputs. For example, if we went to this, the giant monitor
> >> > attached to my laptop that I actually look at would go unused.
> >>
> >> yeah, normally VBIOS startup just needs or only can driver one pipe, so
> >> we don't have any pre knowledge except detect everything.
> >
> > Umm. What's your guys point, exactly?
> >
> > The fact is, as-is, YOU DETECT THE WRONG OUTPUTS!
> >
> > If you actually detected things _right_, none of this would be an issue.
> > But you don't. And you seem to have a really hard time even admitting
> > that. You try to re-detect things, and you SCREW UP.
> This isn't anything to do with redetection, and in the Mac case there isn't
> even a BIOS table that you can really rely on since Apple hard coded all
> this stuff into their EFI and Mac OSX drivers.
> Now you probably get a video bios using Apples bios layer, but it also
> is most likely not telling anything close to the truth about the hw layout.
> Just because the BIOS manages to light up an output in now way effects
> whether the driver can do the same.
> >
> >> we already have some mac relate bugs open, but please report on it so we
> >> do have people with hardware to try and response. We have recently got a
> >> MacBook, yakui is looking after the modesetting issue on it.
> >
> > Quite frankly, I've reported these things several times. I've been open to
> > try patches. Nothing has ever come out of it.
> >
> > I have a Mac Mini that I reported as broken over a month ago. I have a
> > Westemere I've reported as not doing any DDC probing - and that I have to
> > disable the LVDS probing on entirely in order to not make KMS set up the
> > display to go to a non-existent LVDS port.
> >
> > You claim that you "detect everything", but quite frankly, you don't. The
> > KMS code seems to assume that if it's a mobile chipset, it should have an
> > LVDS output - and whether anything is connected to that or not is totally
> > immaterial. There's clearly _zero_ "detection" going on.
> >
> > And the thing is, X seems to get it right, at least more often than KMS
> > does.
> >
> I'm not sure why the mac-mini hack hasn't been merged I asked for it a
> few times,
> I'd rather the proper solution was merged but that seems to not have
> happened either.

Your complaint about needing to do the proper solution was why I never
merged it. It looked like a NAK to me.

Eric Anholt
eric@xxxxxxxxxx eric.anholt@xxxxxxxxx

Attachment: signature.asc
Description: This is a digitally signed message part