Re: [PATCH 1/2] trace_events: fix napi's tracepoint

From: Xiao Guangrong
Date: Wed Aug 26 2009 - 01:41:11 EST

Xiao Guangrong wrote:
> Xiao Guangrong wrote:
>> Currently, the napi's tracepoint works will is depend on
>> "DECLARE_TRACE" definiens in include/trace/define_trace.h,
>> like below:
>> #include <trace/events/skb.h> // include define_trace.h
>> #include <trace/events/napi.h>
>> there have error, if we remove "#include <trace/events/skb.h>"
>> or include napi.h in the front of include skb.h, It should
>> depend on the definiens in include/linux/tracepoint.h and we
>> can remove the "DECLARE_TRACE" definiens in
>> include/trace/define_trace.h, because "TRACE_EVENT" not use it
>> Signed-off-by: Xiao Guangrong <xiaoguangrong@xxxxxxxxxxxxxx>
> Hi Steven,
> I'm sorry, please pull this patch too, because
> "[PATCH 7/8] tracing/events: fix the include file dependencies"
> is based on this patch, else will occur building error.

Sorry again, I say the wrong words, it not has building error, just
not complete fix the bug which I mention it in the changelog of
"[PATCH 7/8] tracing/events: fix the include file dependencies", that
is we can't include more TRACE_EVENT head file in .c file all the same,
like below:

Both define TRACE_EVENT in trace_a.h and trace_b.h, if we include
those in .c file, like this:

include <trace/events/trace_a.h> // re-define DECLARE_TRACE

include <trace/events/trace_b.h> // use the DECLARE_TRACE definition
// that re-define by trace_a.h


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at