Re: Initial work for ar9271

From: Joe Perches
Date: Wed Aug 26 2009 - 00:32:00 EST


On Tue, 2009-08-25 at 21:03 -0700, Luis R. Rodriguez wrote:
> If you'd like to work on the
> driver I welcome patches:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/ar9271.git

I think this style ugly because it's non kernel standard.

int func(args)
{
do {
[ linear code ...]
if (err) {
errorcode = ;
break;
}
[ more linear code ...]
} while (0);

if (errorcode) {
handle()...
return some_err;
}

return 0;
}

It's a bit too much like a try/throw/catch block.

Are patches accepted to convert it to the more
commonly used kernel style using gotos?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/