Re: [PATCH 2/3] inotify: do not BUG on idr entries at inotifydestruction

From: Linus Torvalds
Date: Mon Aug 24 2009 - 15:23:47 EST

On Mon, 24 Aug 2009, Eric Paris wrote:
> You suspect correctly. :( I'll fix in my tree before I request a
> pull....

Can you change the WARN() to a WARN_ONCE() too.

Generally, we prefer the "ONCE" variant if there isn't some intrisic
reason why we'd want to know about each event. If there is some load that
triggers this, do you care about _how_many_times_ it happens, or about the
fact that it happens in the first place? In this case, I think it's the
"happens in the first place" case - once you see it a single time, the
rest of the reports aren't that interesting.

And using the ONCE thing means that we know it's not going to spam the

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at