Re: kmemleak: Protect the seq start/next/stop sequencebyrcu_read_lock()

From: Catalin Marinas
Date: Fri Aug 14 2009 - 18:45:34 EST


Hi Ingo,

On Wed, 2009-08-12 at 21:52 +0100, Ingo Molnar wrote:
> * Catalin Marinas <catalin.marinas@xxxxxxx> wrote:
>
> > kmemleak: Allow rescheduling during an object scanning
>
> i tried this in -tip testing, and it crashes quickly:
>
> [ 81.900051] BUG: unable to handle kernel paging request at ffff880020000000
> [ 81.901382] IP: [<ffffffff8112ae7e>] scan_block+0xee/0x190

I updated the original patch for cond_resched() slightly (to check for
objects they may be annotated during a scan_block loop). I also added a
patch with an annotation for the memory hole at 0x20000000 on your
x86_64 platform. I don't have such hardware to be able to check, so I
would be grateful if you can acknowledge them.

I'll post the patches as replies to this e-mail.

Thanks.

--
Catalin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/