Re: [RFC patch 2/3] genirq: Add buslock support for irq chips onslow busses

[Peter Zijlstra]

On Thu, 2009-08-13 at 19:40 +0000, Thomas Gleixner wrote:
>  
> +/**
> + *	disable_slowbus_irq - disable an slowbus irq and wait for completion
> + *	@irq: Interrupt to disable
> + *
> + *	Disable the selected interrupt line.  Enables and Disables are
> + *	nested.
> + *	This function waits for any pending IRQ handlers for this interrupt
> + *	to complete before returning. If you use this function while
> + *	holding a resource the IRQ handler may need you will deadlock.
> + *
> + *	This function must not be called from IRQ context.
> + */
> +void disable_slowbus_irq(unsigned int irq)
> +{
> +	struct irq_desc *desc = irq_to_desc(irq);
> +
> +	if (!desc || !desc->chip || !desc->chip->bus_lock)
> +		return;
> +
> +	desc->chip->bus_lock(irq);
> +	disable_irq_nosync(irq);
> +	if (desc->action)
> +		synchronize_irq(irq);
> +	desc->chip->bus_sync_unlock(irq);
> +}
> +EXPORT_SYMBOL(disable_slowbus_irq);

Should we also not check that desc->chip->bus_lock is not set for the
regular function disable_irq()?

It seems to me mixing disable_irq() and disable_slowbus_irq() is a
recipe for disaster.

Same for the other slowbus functions of course.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/