Re: [PATCH 2/2] x86: Clear incorrectly forced X86_FEATURE_LAHF_LMflag

[Borislav Petkov]

On Thu, Aug 13, 2009 at 10:21:22AM -0400, Brian Gerst wrote:
> > +               /*
> > +                * Some BIOSes incorrectly force this feature, but only K8
> > +                * revision D (model = 0x14) and later actually support it.
> > +                */
> > +               if (c->x86_model < 0x14) {
> 
> Shouldn't you test that the flag is actually set before trying to clear it?

Yep, I'll do that in the final version of the patches.

-- 
Regards/Gruss,
Boris.

Operating | Advanced Micro Devices GmbH
  System  | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. München, Germany
 Research | Geschäftsführer: Thomas M. McCoy, Giuliano Meroni
  Center  | Sitz: Dornach, Gemeinde Aschheim, Landkreis München
  (OSRC)  | Registergericht München, HRB Nr. 43632

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/