Re: [RFC patch] init default dma_ops to prepare intel_iommu_init failure

[FUJITA Tomonori]

On Thu, 13 Aug 2009 09:26:12 +0100
David Woodhouse <dwmw2@xxxxxxxxxxxxx> wrote:

> On Thu, 2009-08-13 at 12:18 +0900, FUJITA Tomonori wrote:
> > > Duh, yeah, intel_iommu_init() fails, it doesn't work.
> > > 
> > > X86 falls back into nommu_dam_ops but IA64 has nothing.
> > > 
> > > pci_swiotlb_init() can't set swiotlb to 1 or overwrite dma_ops? If it
> > > sets swiotlb to 1, intel_iommu_init() fails.
> > > 
> > > A quick fix could be something like this:
> > 
> > Oops, here's a good one.
> 
> Closer, but don't we still want to free the swiotlb buffers if the iommu
> init _does_ actually work?

If we want to fix this right now, this should be applied:

http://marc.info/?l=linux-kernel&m=125014640502047&w=2

It allocates swiotlb buffer only if we actually use it.

But seems that this is not an urgent issue so I'll work on the IA64
and X86 dma bootup code again for 2.6.32 or 33.

> And we want the same on x86 too -- we want swiotlb, not nommu.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/