Re: [PATCH 2.6.32 v3] Conditional MSI support for sata_nv

[Leon Woestenberg]

Hello,

On Thu, Aug 6, 2009 at 1:50 AM, Tony Vroon<tony@xxxxxxxx> wrote:
> At least the nVidia MCP55 controller quite happily supports MSI.
> +static int msi_enabled;
> +       if (msi_enabled) {
> +               dev_printk(KERN_NOTICE, &pdev->dev, "Using MSI\n");
> +               pci_enable_msi(pdev);
> +       }
> +

I just saw this patch, didn't check the full sources.

Shouldn't there be a matching "if (msi_enabled)
pci_disabling_msi(pdev);" somewhere else?

Regards,

Leon.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/