Re: [PATCH] pata_atiixp: fix slave device support

From: Jeff Garzik
Date: Wed Aug 12 2009 - 06:26:28 EST


Bartlomiej Zolnierkiewicz wrote:
On Thursday 06 August 2009 17:40:15 Bartlomiej Zolnierkiewicz wrote:
From: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
Subject: [PATCH] pata_atiixp: fix slave device support

Argh, I pushed the "Send" button too quick..

Below version with the correct patch description
(I doubt that this fix will help with bug #13921)..

From: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
Subject: [PATCH v2] pata_atiixp: fix second channel support

PIO and MWDMA timings are never programmed for the second channel
because timing registers are treated as 16-bit long ones.

The bug is an attixp -> pata_atiixp regression and goes back to:

commit 669a5db411d85a14f86cd92bc16bf7ab5b8aa235
Author: Jeff Garzik <jeff@xxxxxxxxxx>
Date: Tue Aug 29 18:12:40 2006 -0400

[libata] Add a bunch of PATA drivers.

Cc: Krystian Juskowiak <jusko@xxxxxxx>
Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Cc: Borislav Petkov <bbpetkov@xxxxxxxx>
Cc: Robert Hancock <hancockrwd@xxxxxxxxx>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
---
After this patch pata_atiixp still have two bugs (+ few superfluous oddities)
not present in atiixp (although not as severe as this one)..

drivers/ata/pata_atiixp.c | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)

applied


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/