Re: [PATCH RT 8/6] [ARM, WATCHDOG] davinci: include mach/timex.hin davinci_wdt.c

From: Russell King - ARM Linux
Date: Mon Aug 10 2009 - 18:03:10 EST


On Mon, Aug 10, 2009 at 02:04:31PM -0700, Kevin Hilman wrote:
> @@ -86,6 +88,9 @@ static void wdt_enable(void)
> {
> u32 tgcr;
> u32 timer_margin;
> + u32 wdt_freq;
> +
> + wdt_freq = clk_get_rate(wdt_clk);

Much better - and only a minor nit which doesn't deserve a repost -
wdt_freq should probably match the return type of clk_get_rate. IOW
unsigned long.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/