Re: [PATCH] Driver Core: devtmpfs - kernel-maintained tmpfs-based/dev

[Greg KH]

On Sun, Aug 09, 2009 at 02:09:02PM +0200, Pavel Machek wrote:
> Hi!
> 
> > --- /dev/null
> > +++ b/drivers/base/devtmpfs.c
> > @@ -0,0 +1,367 @@
> > +/*
> > + * devtmpfs - kernel-maintained tmpfs-based /dev
> > + *
> > + * Copyright (C) 2009, Kay Sievers <kay.sievers@xxxxxxxx>
> > + *
> 
> I'd expect GPL notice here...

But it's not needed, the overall license of the kernel covers it.

> > +#if defined CONFIG_DEVTMPFS_MOUNT
> > +static int dev_mount = 1;
> > +#else
> > +static int dev_mount;
> > +#endif
> 
> 
> A bit too many config options?

It's only 1 option, is that 1 too many for you?

> > +#ifdef CONFIG_BLOCK
> > +static inline int is_blockdev(struct device *dev)
> > +{
> > +	return dev->class == &block_class;
> > +}
> > +#else
> > +static inline int is_blockdev(struct device *dev) { return 0; }
> 
> Should this go to header somewhere?

It could go in device.h, but do others need it?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/