Re: [PATCH 5/6] [NET] ixp2000/enp2611: don't set non-existentmember get_stats

From: David Miller
Date: Mon Aug 10 2009 - 11:00:41 EST


From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Date: Mon, 10 Aug 2009 11:40:27 +0200

> Yes, I tried that, but stopped when I saw it's declared const. I don't
> know if this is required. If yes then the only way to fix it is to add
> a platform callback that is called if non-NULL.

The easiest way to handle this is to have another copy of the ops,
which has the other get_stats member value, and to assign that as
the netdev_ops when the relevant condition holds.

> I don't want to invest time here without a word by the maintainers
> though.

But we can't apply the patch you initially posted, that's for sure
:-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/