Re: [PATCH 1/3] vfs: make get_sb_pseudo set s_maxbytes to valuethat can be cast to signed

From: Jeff Layton
Date: Mon Aug 10 2009 - 10:09:12 EST


On Mon, 10 Aug 2009 09:49:50 -0400
Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:

> On Mon, Aug 10, 2009 at 08:17:41AM -0400, Jeff Layton wrote:
> > get_sb_pseudo sets s_maxbytes to ~0ULL which becomes negative when cast
> > to a signed value. Fix it to use MAX_LFS_FILESIZE which casts properly
> > to a positive signed value.
> >
> > Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>
> > Reviewed-by: Johannes Weiner <hannes@xxxxxxxxxxx>
> > Acked-by: Steve French <smfrench@xxxxxxxxx>
>
> Looks good, and I think it would be very good to still gets this into
> 2.6.31.
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
>

Agreed. The other two should probably go in early 2.6.32 (assuming
they're ok).

--
Jeff Layton <jlayton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/