Re: [PATCH] x86: reget cfg_new in case reuse/move irq_desc

From: Ingo Molnar
Date: Sat Aug 08 2009 - 11:03:02 EST



* Yinghai Lu <yinghai@xxxxxxxxxx> wrote:

> when irq_desc is moved, we need to make sure to use right cfg_new
>
> Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>
>
> ---
> arch/x86/kernel/apic/io_apic.c | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: linux-2.6/arch/x86/kernel/apic/io_apic.c
> ===================================================================
> --- linux-2.6.orig/arch/x86/kernel/apic/io_apic.c
> +++ linux-2.6/arch/x86/kernel/apic/io_apic.c
> @@ -3153,6 +3153,7 @@ unsigned int create_irq_nr(unsigned int
> continue;
>
> desc_new = move_irq_desc(desc_new, node);
> + cfg_new = desc_new->chip_data;
>

i suspect we need this for .31? Did you see any actual bug due to
this? (if yes, how did it look like?)

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/