Re: [PATCH] ring-buffer: Fix memleak in ring_buffer_free()

[Steven Rostedt]

On Fri, 7 Aug 2009, Eric Dumazet wrote:

> I noticed oprofile memleaked in linux-2.6 current tree,
> and tracked this ring-buffer leak.
> 
> This is a stable candidate.

Thanks! I'll pull it in now.

-- Steve

> 
> [PATCH] ring-buffer: Fix memleak in ring_buffer_free()
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@xxxxxxxxx>
> ---
> diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
> index bf27bb7..c1d874e 100644
> --- a/kernel/trace/ring_buffer.c
> +++ b/kernel/trace/ring_buffer.c
> @@ -735,6 +735,7 @@ ring_buffer_free(struct ring_buffer *buffer)
>  
>  	put_online_cpus();
>  
> +	kfree(buffer->buffers);
>  	free_cpumask_var(buffer->cpumask);
>  
>  	kfree(buffer);
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/