perf-record fix and UI improvement

From: Pierre Habouzit
Date: Fri Aug 07 2009 - 08:26:09 EST


While toying with perf, I've noticed that perf record can easily enter
a busy loop when doing something as silly as:

$ perf record -A ls

I've searched why and here are the patches:

[PATCH 1/2] perf util: do_read should fail on EOF instead of busy-looping.

Yeah, do_read here really wants to read a known size, not being able
to should die(), not busy-lopp ;)
That was the cause for the bug.


[PATCH 2/2] perf-record: improve -A UI for empty or non-existent perf.data

Though with 1/2 `git record -A ls` would then fail miserably with
some kind of "cannot read" error, which sucks. So this patch
understands -A as a "append or create if file is empty or inexistant"

This fact may deserve to be documented properly, if so just tell me
I'll send an updated patch for Documentation/


I'm kind of new to the kernel world, so I hope I sent the patches to the
proper persons.
--
Intersec <http://www.intersec.com>
Pierre Habouzit <pierre.habouzit@xxxxxxxxxxxx>
TÃl : +33 (0)1 5570 3346
Mob : +33 (0)6 1636 8131
Fax : +33 (0)1 5570 3332
37 Rue Pierre Lhomme
92400 Courbevoie

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/