Re: [PATCH] perf tools: Fix cumul hit based sub-total

[Peter Zijlstra]

On Fri, 2009-08-07 at 07:11 +0200, Frederic Weisbecker wrote:
> The callchain fractal mode builds each new total hits in a new branch
> of profiling by using the parent's hits of the current branch plus the
> hits of the children.
> 
> This is wrong, the total hits of a branch should be made of the sum of
> every children hits, we must ignore the parent hits in this scope.
> 
> This patch also fixes another mistakes with the hit counting.
> 
> Now the rates are corrects.
> 
> Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Mike Galbraith <efault@xxxxxx>
> ---

Ah will this fix these instances where you'd have things like

                |                     page_fault
                |                     |
                |                     |--100.00%-- __strcmp_sse2
                |                     |          copy_dep_chain
                |                     |          __libc_start_main
                |                     |
                |                      --100.00%-- gettimeofday
                |                                __libc_start_main


I was meaning to poke you about that :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/