Re: [PATCH v2 2/3] tracing/filters: Add __field_ext() toTRACE_EVENT

[Steven Rostedt]

On Fri, 7 Aug 2009, Li Zefan wrote:

> >>  #define is_signed_type(type)	(((type)(-1)) < 0)
> >>  
> >> @@ -165,7 +172,7 @@ do {									\
> >>  #define __common_field(type, item, is_signed)				\
> >>  	ret = trace_define_field(event_call, #type, "common_" #item,	\
> >>  				 offsetof(typeof(field.ent), item),	\
> >> -				 sizeof(field.ent.item), is_signed);	\
> >> +				 sizeof(field.ent.item), is_signed, -1);\
> > 
> > I think this wants to be FILTER_OTHER?
> > 
> 
> oops.. I thought I had changed all -1 to FILTER_OTHER..
> 
> I guess you're going to fix this manually?

Yeah, I can make that change.

Thanks!

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/