RE: [PATCH 2.6.32 v2] MCP55 SATA2 conditional MSI support forsata_nv

From: Tony Vroon
Date: Thu Aug 06 2009 - 12:07:03 EST


> disable_msi() is missing right?

I didn't add that as none of the other drivers have it:
chainsaw@amalthea /cvs/linux-2.6/drivers/ata $ grep _msi * | grep pci
ahci.c: pci_enable_msi(pdev);
sata_mv.c: if (msi && pci_enable_msi(pdev) == 0)
sata_vsc.c: if (pci_enable_msi(pdev) == 0)

(This is a tree without the sata_nv change I submitted)

I do believe it is safe to shut the interrupt down and unload the
handler whilst it is still in MSI mode. At least, I don't see the libata
core special-casing it in any way.

> Chetan

Regards,
Tony V.

Attachment: signature.asc
Description: This is a digitally signed message part