Re: [PATCH 2/3] libata: Bind the Linux device tree to the ACPI device tree

[HÃkon LÃvdal]

2009/7/13 Matthew Garrett <mjg@xxxxxxxxxx>:
> + Â Â Â Â Â Â Â if (!sata_pmp_attached(ap))
> + Â Â Â Â Â Â Â Â Â Â Â adr = SATA_ADR(ap->port_no, NO_PORT_MULT);
> + Â Â Â Â Â Â Â else
> + Â Â Â Â Â Â Â Â Â Â Â adr = SATA_ADR(ap->port_no, dev->link->pmp);

Maybe I am missing something, but wouldn't it be more natural to write this as

        if (sata_pmp_attached(ap))
                adr = SATA_ADR(ap->port_no, dev->link->pmp);
        else
                adr = SATA_ADR(ap->port_no, NO_PORT_MULT);

BR HÃkon LÃvdal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/