Re: [PATCH v5 1/3] ftrace: add tracepoint for timer

[Xiao Guangrong]

Anton Blanchard wrote:
> Hi,
> 
>> Example ftrace output:
>>   insmod-1712  [000]   145.901459: timer_init: timer=d0ace4b4
>>   insmod-1712  [000]   145.901469: timer_start: timer=d0ace4b4 func=timer_fun expires=4294813629 timeout=199
>>   <idle>-0     [000]   146.100230: timer_cancel: timer=d0ace4b4
>>   <idle>-0     [000]   146.100233: timer_expire: timer=d0ace4b4 jiffies=4294813629
>>   <idle>-0     [000]   146.100627: timer_callback_done: func=d0ace4b4
> 
> Sorry I haven't followed the thread, but I was wondering why you changed
> the name of the entry and exit tracepoints (ie timer_entry/timer_exit). 
> 
> I think consistent naming is important to match the other static
> tracepoints, such as softirq_entry/softirq_exit, irq_entry/irq_exit and
> tasklet_entry/tasklet_exit.
> 

I rename timer_entry/timer_exit to timer_expire/timer_callback_done just to
match this series:

*_init() -> *_start() -> *_expire()...

It's a complete timer's lifecycle.

Thanks,
Xiao

> Anton
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/