Re: [Patch 2/7] x86: implement crashkernel=auto

From: Amerigo Wang
Date: Wed Aug 05 2009 - 21:43:29 EST


Neil Horman wrote:
What about all the other arches that support kexec? ia64/ppc[64]/s390/etc?
Don't they need an implementation of arch_default_crash_size? Or perhaps better
still you should put this definition in asm-generic, so that it can be
overridden per-arch if need be, but you always have something to fall back on.

Hmm, I think you mean we need ARCH_HAS_XXXX....
OK, it is a good idea, I will try it.

Thanks for your review, Neil.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/