Re: [PATCH] [11/19] HWPOISON: Refactor truncate to allow directtruncating of page v2

From: Andi Kleen
Date: Wed Aug 05 2009 - 09:46:20 EST


On Wed, Aug 05, 2009 at 12:20:08PM +0200, Nick Piggin wrote:
> > truncate_complete_page(struct address_space *mapping, struct page *page)
> > {
> > if (page->mapping != mapping)
> > - return;
> > + return -EIO;
>
> Hmm, at this point, the page must have been removed from pagecache,
> so I don't know if you need to pass an error back?

It could be reused, which would be bad for us?

The final check is the page error count in the end anyways.

-Andi

--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/