Re: [PATCH 0/3] Generic sysfs support for ACPI ALS and other ALS devices

From: Valdis . Kletnieks
Date: Tue Aug 04 2009 - 13:25:39 EST


On Tue, 04 Aug 2009 08:10:42 PDT, Greg KH said:
> On Tue, Aug 04, 2009 at 03:21:29PM +0200, Pavel Machek wrote:
> > On Mon 2009-08-03 17:10:57, Zhang Rui wrote:

> > > cat /sys/class/als/als0/mappings
> > > ???Illuminance Adjustment
> > > 0 70
> > > 10 73
> > > 80 85
> > > 300 100
> > > 1000 150
> >
> > There's one value per file for sysfs... You should definitely have the
> > header.
>
> No, no "header", just don't do this, it's not allowed. Again,
> one-value-per-sysfs-file is the rule, please do not violate it.

What's the intended sysfs solution here, then? Make 'mappings' a directory,
and populate it with files called 0, 10, 80, 300, 1000, each with one number
in them?

Attachment: pgp00000.pgp
Description: PGP signature