Re: [PATCH take 2][RFC] fat: Save FAT root directory timestamps to volume label

From: OGAWA Hirofumi
Date: Tue Aug 04 2009 - 06:32:41 EST


Jörg Schummer <ext-jorg.2.schummer@xxxxxxxxx> writes:

> On Mon, 2009-07-27 at 13:47 +0200, ext OGAWA Hirofumi wrote:
>> Jörg Schummer <ext-jorg.2.schummer@xxxxxxxxx> writes:
>
>> BTW, the patch has several bugs. fat_get_label_entry() doesn't check
>> IS_FREE(), is it right? fat_create_label_entry() doesn't initialize all
>> timestamp in the case of msdos. spin_lock() usage is wrong. and more...
>
> After reviewing the patch again, I did notice some additional problems
> (I suppose that was the "and more..."). If and when I have time again, I
> might take a closer look at it again.
>
> Thanks for your help until now!

No problem at all. Thanks for your work.
--
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/