Re: [PATCH 0/9] Per-bdi writeback flusher threads v13

From: Damien Wyart
Date: Mon Aug 03 2009 - 15:29:47 EST


> > fs/sync.c has changed some time ago and I think your patch needs this
> > (which I had lazyly added by hand in v12 without telling):

> > --- a/fs/sync.c 2009-07-31 07:32:08.927926281 +0200
> > +++ b/fs/sync.c 2009-07-31 07:31:52.499801359 +0200
> > @@ -118,7 +118,7 @@ restart:
> > */
> > SYSCALL_DEFINE0(sync)
> > {
> > - wakeup_pdflush(0);
> > + wakeup_flusher_threads(0);
> > sync_filesystems(0);
> > sync_filesystems(1);
> > if (unlikely(laptop_mode))

* Jens Axboe <jens.axboe@xxxxxxxxxx> [2009-07-31 09:15]:
> Argh, I had fixed that long ago, but a branch problem yesterday caused
> it to be lost just before posting. How annoying. Thanks for the hint,
> I'll update the v13 branch and patch.

Mmm. I wanted to test v13 on another machine and re-downloaded the patch
this morning (Paris time) but it seems completly wrong. It applied
cleany but I did not even try to compile as the files changed seemed
completely unrelated to per-bdi writeback. I guess there has been an
error in generating it.

Best,
--
Damien Wyart
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/