RE: [PATCH] Moorestown RAR Handler driver, MRST 2.6.31-rc3

[Joe Perches]

On Mon, 2009-08-03 at 10:32 -0700, Othman, Ossama wrote:
> >It is recommended to separate definition,
> >and assignment.
> >So this should look like this:
> >	struct memrar_allocator *allocator;
> >	allocator = 0;
> Okay, I'll fix that, too.  Should this go into Documentation/CodingStyle, too?

I don't agree with that at all, neither does a lot of the kernel source.

Automatic structs with initializers:
$ grep -rP --include=*.c "^\s+struct\s+\w+\s*\*\s*\w+\s*=\s*\w+\s*;" * | wc -l
9498

I think it should be struct memrar_allocator *allocator = NULL;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/