Re: [patch] slub: use size and objsize orders to disable debugflags

From: Christoph Lameter
Date: Mon Aug 03 2009 - 10:56:56 EST



Acked-by: Christoph Lameter <cl@xxxxxxxxxxxxxxxxxxxx>

On Mon, 27 Jul 2009, David Rientjes wrote:
> @@ -2488,6 +2474,18 @@ static int kmem_cache_open(struct kmem_cache *s, gfp_t gfpflags,
>
> if (!calculate_sizes(s, -1))
> goto error;
> + if (disable_higher_order_debug) {
> + /*
> + * Disable debugging flags that store metadata if the min slab
> + * order increased.
> + */
> + if (get_order(s->size) > get_order(s->objsize)) {
> + s->flags &= ~DEBUG_METADATA_FLAGS;

> + s->offset = 0;

Hmmm... Move this line into calculate_sizes()?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/