RE: [PATCH] dmaengine: at_hdmac: add DMA slave transfers

From: Sosnowski, Maciej
Date: Mon Jul 27 2009 - 09:25:11 EST


Haavard Skinnemoen wrote:
> On Fri, 24 Jul 2009 22:29:19 +0900 (JST)
> Atsushi Nemoto <anemo@xxxxxxxxxxxxx> wrote:
>
>>> The patches for adaptation of atmel-mci to at_hdmac are coming...
>>
>> Your atc_chain_complete() calls dma_unmap_xxx unless
>> DMA_COMPL_SKIP_XXX_UNMAP specified. But atmel-mci driver does not set
>> the flag on dma_async_tx_descriptor. I suppose one of them should be
>> fixed.
>
> atmel-mci should definitely set that flag.
>
> Haavard

I agree with Haavard.

Regards,
Maciej--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/