Re: [PATCH 4/5] dma-debug: disable/enable irqs only once in device_dma_allocations
From: Leon Woestenberg
Date: Thu Jul 23 2009 - 14:43:38 EST
Hello,
On Mon, Jun 8, 2009 at 4:34 PM, Joerg Roedel<joerg.roedel@xxxxxxx> wrote:
> There is no need to disable/enable irqs on each loop iteration. Just
> disable irqs for the whole time the loop runs.
>
A typical need would be low interrupt latency.
> Signed-off-by: Joerg Roedel <joerg.roedel@xxxxxxx>
> ---
> lib/dma-debug.c | 8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/lib/dma-debug.c b/lib/dma-debug.c
> index 24c4a2c..27b369d 100644
> --- a/lib/dma-debug.c
> +++ b/lib/dma-debug.c
> @@ -649,15 +649,19 @@ static int device_dma_allocations(struct device *dev)
> unsigned long flags;
> int count = 0, i;
>
> + local_irq_save(flags);
> +
> for (i = 0; i < HASH_SIZE; ++i) {
> - spin_lock_irqsave(&dma_entry_hash[i].lock, flags);
> + spin_lock(&dma_entry_hash[i].lock);
> list_for_each_entry(entry, &dma_entry_hash[i].list, list) {
> if (entry->dev == dev)
> count += 1;
> }
> - spin_unlock_irqrestore(&dma_entry_hash[i].lock, flags);
> + spin_unlock(&dma_entry_hash[i].lock);
> }
>
> + local_irq_restore(flags);
> +
> return count;
> }
Does this mean that on a UP system, interrupts are disabled for O(HASH_SIZE)?
How would that affect interrupt latencies?
Regards,
--
Leon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/