Re: [PATCH] hp-wmi: improve rfkill support

From: Maciej Rutecki
Date: Thu Jul 23 2009 - 11:31:57 EST


2009/7/21 Alan Jenkins <alan-jenkins@xxxxxxxxxxxxxx>:
> 1) Add support for reading the hardware blocked state. ÂPreviously
> Â we read a combination of the hardware and software blocked states,
> Â reporting it as the software blocked state. ÂThis caused some
> Â confusing behaviour.
>
> 2) The software state is persistent, mark it as such.
>
> 3) Check rfkill in the resume handler. ÂBoth the hard and soft
> Â blocked states may change over hibernation.
>
> Signed-off-by: Alan Jenkins <alan-jenkins@xxxxxxxxxxxxxx>
> Tested-by: Maciej Rutecki <maciej.rutecki@xxxxxxxxx>

It's this patch is added to -rc4? I one case I have strange behaviour.

Before disable by button:
root@gumis:/home/maciek/Desktop# rfkill list
2: hp-wifi: Wireless LAN
Soft blocked: no
Hard blocked: no
3: hp-bluetooth: Bluetooth
Soft blocked: no
Hard blocked: no
16: hci0: Bluetooth
Soft blocked: no
Hard blocked: no
17: phy7: Wireless LAN
Soft blocked: no
Hard blocked: no

Disable by button:
root@gumis:/home/maciek/Desktop# rfkill list
2: hp-wifi: Wireless LAN
Soft blocked: yes
Hard blocked: no
3: hp-bluetooth: Bluetooth
Soft blocked: yes
Hard blocked: no
17: phy7: Wireless LAN
Soft blocked: no
Hard blocked: yes

I do s2disk. After resume from suspend to disk (still disabled by button):
root@gumis:/home/maciek/Desktop# rfkill list
2: hp-wifi: Wireless LAN
Soft blocked: yes
Hard blocked: no
3: hp-bluetooth: Bluetooth
Soft blocked: yes
Hard blocked: no
18: phy8: Wireless LAN
Soft blocked: no
Hard blocked: yes

Try enable by button:
root@gumis:/home/maciek/Desktop# rfkill list
2: hp-wifi: Wireless LAN
Soft blocked: yes
Hard blocked: no
3: hp-bluetooth: Bluetooth
Soft blocked: yes
Hard blocked: no
18: phy8: Wireless LAN
Soft blocked: no
Hard blocked: yes

Nothing change (LED, wireless and bluetooth don't work). To enable it
I use this script rfkill.sh (I must use rfkill program):

#!/bin/sh
PROGRAM=/usr/local/sbin/rfkill
WIFI=`$PROGRAM list | grep -E 'Wireless|Bluetooth' | cut -d ':' -f 1`

for DEVICE in $WIFI; do
echo $DEVICE
$PROGRAM unblock $DEVICE
done

Then works OK:
root@gumis:/home/maciek/Desktop# ./rfkill.sh
2
3
18
root@gumis:/home/maciek/Desktop# rfkill list
2: hp-wifi: Wireless LAN
Soft blocked: no
Hard blocked: no
3: hp-bluetooth: Bluetooth
Soft blocked: no
Hard blocked: no
18: phy8: Wireless LAN
Soft blocked: no
Hard blocked: no
19: hci0: Bluetooth
Soft blocked: no
Hard blocked: no

It's normal behaviour?

--
Maciej Rutecki
http://www.maciek.unixy.pl
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/