Re: [PATCH] Add reboot fixup for SBC-fitPC2

From: H. Peter Anvin
Date: Wed Jul 22 2009 - 21:25:00 EST


On 07/22/2009 05:38 PM, Andrew Morton wrote:
>
> Neither this patch nor Denis's earlier version contained an adequate
> decription. We aren't told what these "problems" are, so we're unable
> to judge the appropriateness of patch.
>
> Both patches were wordwrapped.
>
> Both patches use an atypical layout style for the comments.
>
> I fixed up some of these things and merged the patch into my tree, for
> sending to Ingo for 2.6.32.
>
> Please send a description of the problem which the patch fixes and I
> shall add that to my copy of the changelog.
>

I queued up an equivalent cleaned up version for tip:x86/urgent that I
was planning to push to Linus. However, as you quite correctly point
out the comments in this file are pretty darn pointless; they add
absolutely no information over what is already in the data structure.

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/