Re: [PATCH -v2 1/2] VM/SELinux: require CAP_SYS_RAWIO for allmmap_zero operations

[James Morris]

On Tue, 21 Jul 2009, Eric Paris wrote:

> +
> +	if ((addr < mmap_min_addr) && !capable(CAP_SYS_RAWIO))
> +		return -EACCES;

Please make this check a static inline.  Less chance of someone breaking 
it, or it having some subtle bug, and easier to maintain.

>  	address &= PAGE_MASK;
> +

Whitespace leak.


- James
-- 
James Morris
<jmorris@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/