Re: [PATCH] sysrq, kdump: fix regression, revert "simplify sysrq-c handler"

[Eric W. Biederman]

Lai Jiangshan <laijs@xxxxxxxxxxxxxx> writes:

> Even I agreed your fix, I don't agreed your naming,
> For your fix, the correct naming should be:
>
> .help_msg       = "oops(C)",
> .action_msg     = "Trigger an oops"
>
> And document it:
> Sysrq-c always causes an oops by an indirect way. It'll do one of 4 things:
> 1) panic_on_oops=0, it is just kill the current task.
> 2) panic_on_oops=1, but CONFIG_KEXEC=n, just normal panic
> 3) panic_on_oops=1, CONFIG_KEXEC=y, but not enabled, just normal panic
> 4) panic_on_oops=1, CONFIG_KEXEC=y, kdump was enabled, CrashDump.


That sounds like a great way to sort out the understanding.

Acked-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>

Could you turn that into a proper patch?


Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/