Re: [RFC][patch 3/5] remove clocksource inline functions

[Daniel Walker]

On Tue, 2009-07-21 at 21:17 +0200, Martin Schwidefsky wrote:
> plain text document attachment (clocksource-inline.diff)
> From: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
> 
> Remove clocksource_read, clocksource_enable and clocksource_disable
> inline functions. No functional change.
> 
> Cc: Ingo Molnar <mingo@xxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: john stultz <johnstul@xxxxxxxxxx>
> Signed-off-by: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
> ---
>  kernel/time/clocksource.c |   18 ++++++++++++------
>  kernel/time/timekeeping.c |   13 ++++++-------
>  2 files changed, 18 insertions(+), 13 deletions(-)
> 
> Index: linux-2.6/kernel/time/clocksource.c
> ===================================================================
> --- linux-2.6.orig/kernel/time/clocksource.c
> +++ linux-2.6/kernel/time/clocksource.c
> @@ -517,7 +517,7 @@ void clocksource_forward_now(void)
>  	cycle_t cycle_now, cycle_delta;
>  	s64 nsec;
>  
> -	cycle_now = clocksource_read(clock);
> +	cycle_now = clock->read(clock);

What the benefit of this? You get the same result either way. I think
it's actually less error prone (less confusing) using the inlines ..

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/