Re: [PATCH 2/2] perf_counter: detect debugfs location

[Ray Lee]

On Tue, Jul 21, 2009 at 9:44 AM, Steven Rostedt<rostedt@xxxxxxxxxxx> wrote:
>
> On Tue, 21 Jul 2009, Ray Lee wrote:
>
>> On Tue, Jul 21, 2009 at 9:20 AM, Jason Baron <jbaron@xxxxxxxxxx> wrote:
>> >
>> > Search for the debugfs filesystem in /proc/mounts, but also allows the user to
>> > specify '--debugfs-dir=blah' or set the environment variable: 'PERF_DIR_DEBUGFS'
>>
>> > -static char default_debugfs_path[] = "/sys/kernel/debug/tracing/events";
>>
>> There are server systems out there that run with thousands of mounts.
>> It would be kinder to the users of those systems (ie, faster perf
>> startup) if you only went rooting around /proc/mounts if opening the
>> default location failed.
>
> Well, those that have thousand of mounts could probably get away with
> setting PERF_DIR_DEBUGFS in /etc/profile.

The intent of the patch is obviously to try to Do The Right Thing by
default. I think that's great. I just think it should DT(fast and)RT
instead.

> But, a simple stat("/sys/kernel/debug/tracing") should be easy enough.

<nod>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/