Re: [PATCH v2] tracing/filters: Improve subsystem filter

[Steven Rostedt]

On Tue, 21 Jul 2009, Li Zefan wrote:
> >> 2:
> >>   # cat filter
> >>   irq == not_num
> >>   ^
> >>   parse_error: Couldn't find or set field in one of a subsystem's events
> > 
> > This looks good, BUT, it is too much. If you want to implement an error 
> > message like the above, it should probably be a "pr_info()" thing.
> > 
> 
> Yeah, I think it's too much too, but that's exactly what we have.
> And I posted a patch to remove those error messages, but Tom and
> Frederic didn't seem to like it:
> 
> 	http://lkml.org/lkml/2009/6/17/89
> 

Ah, I forgot about that thread. Well, Frederic did mention making a 
"filter_error" file. That sounds like a good solution to me. But I have no 
strong opinions on this one way or another.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/