Re: [PATCH] [usb-serial] fix Ooops on uplug

From: Alan Cox
Date: Mon Jul 20 2009 - 19:32:19 EST


On Mon, 20 Jul 2009 19:51:53 +0200
Daniel Mack <daniel@xxxxxxxx> wrote:

> When an USB serial adapter is disconnected and <Enter> is pressed on a
> connection still open on it (cu, minicom, ...), the kernel crashes.
>
> The reason is that the serial port's resources are freed upon disconnect
> (in serial_hangup()) but the tty device layer is not made aware of that.
> Hence, the close callback will later access the resources again.

I don't think that is the case. The hangup terminates access to the
resources and replaces the file operations at tty level. The tty
level close called will be the close for the hung up tty ops not the usb
device ops.

hangup() is a termination of access to the bus resources for that tty
handle.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/