Re: [PATCHv5] uio: add generic driver for PCI 2.3 devices

From: Greg KH
Date: Mon Jul 20 2009 - 16:00:03 EST


On Mon, Jul 20, 2009 at 10:52:27PM +0300, Michael S. Tsirkin wrote:
> On Mon, Jul 20, 2009 at 09:09:43PM +0200, Hans J. Koch wrote:
> > On Mon, Jul 20, 2009 at 10:29:34AM +0300, Michael S. Tsirkin wrote:
> > > This adds a generic uio driver that can bind to any PCI device. First
> > > user will be virtualization where a qemu userspace process needs to give
> > > guest OS access to the device.
> > >
> > > Interrupts are handled using the Interrupt Disable bit in the PCI command
> > > register and Interrupt Status bit in the PCI status register. All devices
> > > compliant to PCI 2.3 (circa 2002) and all compliant PCI Express devices should
> > > support these bits. Driver detects this support, and won't bind to devices
> > > which do not support the Interrupt Disable Bit in the command register.
> > >
> > > It's expected that more features of interest to virtualization will be
> > > added to this driver in the future. Possibilities are: mmap for device
> > > resources, MSI/MSI-X, eventfd (to interface with kvm), iommu.
> >
> > Thanks for adding the docs! Looks alright to me.
> >
> > Thanks,
> > Hans
> >
> > >
> > > Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
> > > Acked-by: Chris Wright <chrisw@xxxxxxxxxx>
> >
> > Signed-off-by: Hans J. Koch <hjk@xxxxxxxxxxxxx>
>
> Jesse just acked this patch in a private mail, as well.
> Acked-by: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>

Odd, but ok...

I'll queue it up now.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/